Gas Optimizations #171

code423n4 · 2022-07-02T18:54:15Z

Use Custom Error instead of Revert / Require String to Save Gas

Custom error from solidity 0.8.4 are cheaper than revert strings, custom error are defined using the error statement can use inside and outside the contract.

source https://blog.soliditylang.org/2021/04/21/custom-errors/

i suggest replacing revert / require error strings with custom error.

POC :

> 0 is less efficient than != 0 for unsigned integers

!= 0 costs less gas compared to > 0 for unsigned integers in require statements with the optimizer enabled (6 gas)

While it may seem that > 0 is cheaper than !=, this is only true without the optimizer enabled and outside a require statement. If you enable the optimizer at 10k AND you’re in a require statement, this will save gas.

source : https://twitter.com/gzeon/status/1485428085885640706

I suggest changing > 0 with != 0

POC :

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-core.sol#L289
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-core.sol#L306

useage of uint / int smaller than 32 bytes incurs overhead

When using elements that are smaller than 32 bytes, your contract’s gas usage may be higher. This is because the EVM operates on 32 bytes at a time. Therefore, if the element is smaller than that, the EVM must use more operations in order to reduce the size of the element from 32 bytes to the desired size.

resource : https://docs.soliditylang.org/en/v0.8.11/internals/layout_in_storage.html

Use a larger size then downcast where needed

POC :

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-core.sol#L43
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-core.sol#L524
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-periphery.sol#L350
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-periphery.sol#L369
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Stableswap/BaseV1-periphery.sol#L491
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/WETH.sol#L8

Consider making some constants as non-public to save gas

Reducing from public to private or internal can save gas when a constant isn’t used outside of its contract. I suggest changing the visibility from public to internal or private.

POC :

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Governance/GovernorBravoDelegate.sol#L12
https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/NoteInterest.sol#L20

The text was updated successfully, but these errors were encountered:

GalloDaSballo · 2022-08-14T20:47:04Z

Less than 100 gas saved

code423n4 added bug Something isn't working G (Gas Optimization) old-submission-method labels Jul 2, 2022

code423n4 added a commit that referenced this issue Jul 2, 2022

Fitraldys issue #171

03a3e92

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gas Optimizations #171

Gas Optimizations #171

code423n4 commented Jul 2, 2022

GalloDaSballo commented Aug 14, 2022

Gas Optimizations #171

Gas Optimizations #171

Comments

code423n4 commented Jul 2, 2022

GalloDaSballo commented Aug 14, 2022