Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbounded AMMs can cause DOS #41

Closed
code423n4 opened this issue Feb 21, 2022 · 1 comment
Closed

Unbounded AMMs can cause DOS #41

code423n4 opened this issue Feb 21, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-02-hubble/blob/8c157f519bc32e552f8cc832ecc75dc381faa91e/contracts/ClearingHouse.sol#L122

Vulnerability details

Impact

The ClearingHouse.updatePositions function iterates over all amms.
There is no limit to the number of AMMs that can be added in ClearingHouse.whitelistAmm.

The transactions can fail if the arrays get too big and the transaction would consume more gas than the block limit.
This will then result in a denial of service for the desired functionality and break core functionality.
It also leads to a higher gas cost.

A similar issue was recently marked as medium severity.

Recommended Mitigation Steps

It would be best to set a sanity maximum number of AMMs/ that can be added.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Feb 21, 2022
code423n4 added a commit that referenced this issue Feb 21, 2022
@code423n4
cmichel issue #41
af9fd89
@atvanguard
Copy link
Collaborator

Duplicate of #97

@atvanguard atvanguard marked this as a duplicate of #97 Feb 24, 2022
@atvanguard atvanguard added the duplicate This issue or pull request already exists label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atvanguard @code423n4