Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe Approve Function Is Deprecated - safeIncreaseAllowance and safeDecreaseAllowance commented out #229

Closed
code423n4 opened this issue Feb 2, 2022 · 1 comment
Closed

Safe Approve Function Is Deprecated - safeIncreaseAllowance and safeDecreaseAllowance commented out #229

code423n4 opened this issue Feb 2, 2022 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

defsec

Vulnerability details

Impact

On the helper contract, It has been observed that to safeIncreaseAllowance and safeDecreaseAllowance are commented out. (OpenZeppelin/openzeppelin-contracts#2268) safeApprove function is deprecated.

Proof of Concept

  1. Navigate to the following contract.

https://github.com/code-423n4/2022-01-openleverage/blob/main/openleverage-contracts/contracts/lib/TransferHelper.sol#L49

Tools Used

Code Review

Recommended Mitigation Steps

Consider to enable functions and use safeIncreaseAllowance and safeDecreaseAllowance instead of safeApprove.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Feb 2, 2022
code423n4 added a commit that referenced this issue Feb 2, 2022
@code423n4
defsec issue #229
4a52b6d
@ColaM12 ColaM12 added the duplicate This issue or pull request already exists label Feb 3, 2022
@ColaM12
Copy link
Collaborator

ColaM12 commented Feb 3, 2022

Duplicate to #87

@ColaM12 ColaM12 closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @ColaM12