Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safeIncreaseAllowance() Instead of Deprecated safeApprove() #85

Closed
code423n4 opened this issue Dec 10, 2021 · 1 comment
Closed

Use safeIncreaseAllowance() Instead of Deprecated safeApprove() #85

code423n4 opened this issue Dec 10, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

Meta0xNull

Vulnerability details

Impact

safeApprove() is Deprecated because has issues similar to the ones found in {IERC20-approve}, and its usage is discouraged.

Read More: SafeERC20.safeApprove() Has unnecessary and unsecure added behavior
OpenZeppelin/openzeppelin-contracts#2219

Proof of Concept

https://github.com/code-423n4/2021-12-defiprotocol/blob/main/contracts/contracts/Basket.sol#L276-L277
https://github.com/code-423n4/2021-12-defiprotocol/blob/main/contracts/contracts/Factory.sol#L112

Tools Used

Manual Review

Recommended Mitigation Steps

Use safeIncreaseAllowance() Instead of Deprecated safeApprove().
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 10, 2021
code423n4 added a commit that referenced this issue Dec 10, 2021
@code423n4
Meta0xNull issue #85
b1643ca
@frank-beard frank-beard added the duplicate This issue or pull request already exists label Feb 23, 2022
@frank-beard
Copy link
Collaborator

#177

@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@0xleastwood @code423n4 @CloudEllie @frank-beard