Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperatorHelpers.sol: function decodeDataAndRequire state mutability can be restricted to pure #48

Open
code423n4 opened this issue Nov 14, 2021 · 0 comments
Open

OperatorHelpers.sol: function decodeDataAndRequire state mutability can be restricted to pure #48

code423n4 opened this issue Nov 14, 2021 · 0 comments
Assignees
@maximebrugel
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GiveMeTestEther

Vulnerability details

Impact

OperatorHelpers.sol: function decodeDataAndRequire state mutability can be restricted to pure
We don't read any storage variables, only use the arguments therefore, it can be restricted to pure.

Proof of Concept

https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/libraries/OperatorHelpers.sol#L45

Tools Used

Manual Analysis

Recommended Mitigation Steps

set function state mutability to pure
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 14, 2021
code423n4 added a commit that referenced this issue Nov 14, 2021
@code423n4
GiveMeTestEther issue #48
fdfab46
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 16, 2021
This was referenced Nov 16, 2021
Closed
Closed
@alcueca alcueca added G (Gas Optimization) 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation G (Gas Optimization) labels Dec 3, 2021
@maximebrugel maximebrugel mentioned this issue Dec 14, 2021
Merged
@maximebrugel maximebrugel self-assigned this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @alcueca @code423n4