Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division by 0 totalWeights #205

Closed
code423n4 opened this issue Nov 17, 2021 · 1 comment
Closed

Division by 0 totalWeights #205

code423n4 opened this issue Nov 17, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

totalWeights might be zero and this will cause division by 0 runtime error. function _computeShareCount divides by _totalWeights:

  return (_amount * _weight) / _totalWeights;

Admin can accidentaly set totalWeights to 0 in function setRoyaltiesWeight when totalWeights = royaltiesWeight and _weight = 0.

Recommended Mitigation Steps

Consider algorithmitcally enforcing totalWeights > 0 or handle this special case in function _computeShareCount.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
pauliax issue #205
472833d
@adrien-supizet
Copy link
Collaborator

duplicate #43

@adrien-supizet adrien-supizet added the duplicate This issue or pull request already exists label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrien-supizet @code423n4