Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No used library added #114

Open
code423n4 opened this issue Nov 17, 2021 · 1 comment
Open

No used library added #114

code423n4 opened this issue Nov 17, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedBuybacker.sol#L15

There is only NST.safeTransfer used, and NST is INestedToken interface.
SafeERC20 is not used for IERC20 interface.

Tools Used

Recommended Mitigation Steps

Remove Line 79
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
xYrYuYx issue #114
74ab15d
@maximebrugel
Copy link
Collaborator

Remove line 15 (not 79) in NestedBuybacker :
=> https://github.com/code-423n4/2021-11-nested/blob/798909aef382ea6e848f5629cf6daae8111dd777/contracts/NestedBuybacker.sol#L15

@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 19, 2021
@adrien-supizet adrien-supizet mentioned this issue Dec 2, 2021
Merged
@adrien-supizet adrien-supizet self-assigned this Dec 2, 2021
@adrien-supizet adrien-supizet removed their assignment Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @adrien-supizet @code423n4