Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Typos #59

Open
code423n4 opened this issue Oct 14, 2021 · 2 comments
Open

Comment Typos #59

code423n4 opened this issue Oct 14, 2021 · 2 comments
Assignees
@aodhgan
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

leastwood

Vulnerability details

Impact

There are a couple of typos found within the Reserve.sol contract.

Proof of Concept

https://github.com/pooltogether/v4-core/blob/master/contracts/Reserve.sol#L20
https://github.com/pooltogether/v4-core/blob/master/contracts/Reserve.sol#L21

Tools Used

Manual code review

Recommended Mitigation Steps

Consider updating the typo in Reserve.sol:L20 from speicific to specific and the typo in Reserve.sol:L21 from determininstially to deterministically.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding labels Oct 14, 2021
code423n4 added a commit that referenced this issue Oct 14, 2021
@code423n4
leastwood issue #59
ced1052
@aodhgan aodhgan self-assigned this Oct 14, 2021
@aodhgan aodhgan added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Oct 14, 2021
@aodhgan
Copy link
Collaborator

aodhgan commented Oct 14, 2021

done in commit pooltogether/v4-core@5357854

@PierrickGT PierrickGT added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 14, 2021
@GalloDaSballo
Copy link
Collaborator

The sponsor has fixed the typos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aodhgan aodhgan

Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PierrickGT @GalloDaSballo @aodhgan @code423n4