Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close attachments #273

Merged
merged 1 commit into from
Dec 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ dummy_project/*
messages
*.sqlite3
.idea/
venv/
36 changes: 17 additions & 19 deletions django_mailbox/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,6 @@ def html(self):
def _rehydrate(self, msg):
new = EmailMessage()
settings = utils.get_settings()

if msg.is_multipart():
for header, value in msg.items():
new[header] = value
Expand All @@ -696,24 +695,24 @@ def _rehydrate(self, msg):
if encoding and encoding.lower() == 'quoted-printable':
# Cannot use `email.encoders.encode_quopri due to
# bug 14360: http://bugs.python.org/issue14360
output = BytesIO()
encode_quopri(
BytesIO(
attachment.document.read()
),
output,
quotetabs=True,
header=False,
)
new.set_payload(
output.getvalue().decode().replace(' ', '=20')
)
with open(attachment.document.path, 'rb') as f:
output = BytesIO()
encode_quopri(
BytesIO(
f.read()
),
output,
quotetabs=True,
header=False,
)
new.set_payload(
output.getvalue().decode().replace(' ', '=20')
)
del new['Content-Transfer-Encoding']
new['Content-Transfer-Encoding'] = 'quoted-printable'
else:
new.set_payload(
attachment.document.read()
)
with open(attachment.document.path, 'rb') as f:
new.set_payload(f.read())
del new['Content-Transfer-Encoding']
encode_base64(new)
except MessageAttachment.DoesNotExist:
Expand Down Expand Up @@ -777,9 +776,8 @@ def get_email_object(self):
if self.eml.name.endswith('.gz'):
body = gzip.GzipFile(fileobj=self.eml).read()
else:
self.eml.open()
body = self.eml.file.read()
self.eml.close()
with self.eml.open():
body = self.eml.file.read()
else:
body = self.get_body()
flat = email.message_from_bytes(body)
Expand Down