Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation column change in the leaderboard #1630

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Oct 12, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

When updating leaderboard from the UI, changing removing computation from a column was not reflecting after saving the competition. This is now fixed.

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo self-assigned this Oct 12, 2024
@Didayolo Didayolo merged commit 3dc257b into develop Oct 14, 2024
1 check passed
@Didayolo Didayolo deleted the computation_columns branch October 14, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altering leaderboard columns breaks a live contest. No additional saves can be made
2 participants