Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: Avoid depending on two json libraries #495

Merged
merged 2 commits into from
Mar 25, 2024
Merged

clean: Avoid depending on two json libraries #495

merged 2 commits into from
Mar 25, 2024

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Mar 25, 2024

Remove ujson dependency

Copy link

codacy-production bot commented Mar 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.26% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9cc735f) 380 343 90.26%
Head commit (aadbb50) 380 (+0) 344 (+1) 90.53% (+0.26%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#495) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@lolgab lolgab changed the base branch from update-case-app to master March 25, 2024 13:47
@lolgab lolgab requested a review from DMarinhoCodacy March 25, 2024 13:52
DMarinhoCodacy
DMarinhoCodacy previously approved these changes Mar 25, 2024
Copy link
Contributor

@DMarinhoCodacy DMarinhoCodacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lolgab lolgab merged commit 04b2c80 into master Mar 25, 2024
18 checks passed
@lolgab lolgab deleted the remove-ujson branch March 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants