Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php 8.4 deprecation about implicit null arguments #342

Merged
merged 2 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ jobs:
- php: "8.3"
mode: experimental
os: ubuntu-20.04
- php: "8.4"
mode: experimental
os: ubuntu-20.04
fail-fast: false

runs-on: "${{ matrix.os }}"
Expand Down
52 changes: 0 additions & 52 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
}
],
"require": {
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-mbstring": "*"
},
"conflict": {
Expand Down
2 changes: 1 addition & 1 deletion src/Slugify.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class Slugify implements SlugifyInterface
* @param array $options
* @param RuleProviderInterface $provider
*/
public function __construct(array $options = [], RuleProviderInterface $provider = null)
public function __construct(array $options = [], ?RuleProviderInterface $provider = null)
{
$this->options = array_merge($this->options, $options);
$this->provider = $provider ? $provider : new DefaultRuleProvider();
Expand Down
Loading