Cp body #1092
Merged
Cp body #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 5, 2014 16:09
Conflicts: samples/js-tests/src/ChipmunkTest/ChipmunkTest.js
| cc.log(joint); | ||
| }); | ||
| body.eachArbiter(function(arbiter){ | ||
| cc.log(arbiter); |
There was a problem hiding this comment.
There is no arbiter in this test, please add one later.
A test for no arbiter body is also important, so add one arbiter after this eachArbiter call, then do a eachArbiter call again after added one
There was a problem hiding this comment.
we can't add an arbiter manually, arbiter is used internally and we can only retrieve it from callback when collision accurs.
There was a problem hiding this comment.
Ok, I get it, no problem
|
Review done, No problem in the logic Test done on Mac and iOS, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1048