Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add i18n localization files. added --source option. removed pjax function to fix sidebar link update #10

Merged
merged 4 commits into from
Nov 12, 2015

Conversation

nantas
Copy link
Contributor

@nantas nantas commented Nov 11, 2015

fireball-x/fireball#458

…e files. fixed enum display wrong in sidebar.
@yorkie
Copy link
Contributor

yorkie commented Nov 11, 2015

LGTM :-)

@nantas
Copy link
Contributor Author

nantas commented Nov 12, 2015

the last commit solve the sidebar-member template not able to access view.base issue #9

@nantas nantas changed the title added i18n localization files. added --source option add i18n localization files. added --source option Nov 12, 2015
@nantas nantas changed the title add i18n localization files. added --source option add i18n localization files. added --source option. removed pjax function to fix sidebar link update Nov 12, 2015
@nantas
Copy link
Contributor Author

nantas commented Nov 12, 2015

sorry I forgot to open another branch and PR for removing apidocs.js from template reference.

The problem described in #9 (comment) is due to pjax loading not updating sidebar links. Since sidebar links differs for each url, we should probably not using pjax functionality at all? @yorkie can you confirm this? What other functionality is in apidocs.js that we still require?

nantas added a commit that referenced this pull request Nov 12, 2015
add i18n localization files. added --source option. removed pjax function to fix sidebar link update
@nantas nantas merged commit 81b9a78 into cocos-creator:master Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants