ui: Extract Sessions Page from DB Console #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladlos
requested review from
j-low,
laurenbarker and
nathanstilwell
as code owners
|
corresponding pr for admin-ui cockroachdb/cockroach#58034 |
|
@elkmaster can you expand the commit/PR description to include some detail on what's involved here like Andrii did on #162. It's good to have a record if you had to many any changes or adjustments to the code that you copied over. If you made no changes, it's also important to note that. |
dhartunian
requested changes
Dec 23, 2020
packages/admin-ui-components/src/statementsTable/statementsTableContent.tsx
Show resolved
Hide resolved
extract session page into ui repo: - most of the components moved without any or minimal changes - styles converted to scss Resolves: #57296 Release note (ui): none
dhartunian
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui: Extract Sessions Page from DB Console
extract session page into ui repo:
Resolves: #57296
Release note (ui): none