Update sdk to 5.0.0 and add support for cidr_range #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantapop
force-pushed
the
fantapop/CC-30497-terraform-support-cidr-range-attribute-on-cluster-creation
branch
2 times, most recently
from
4893f39
to
5656c89
Compare
fantapop
changed the title
Previously a cluster test was creating a backup configuration that didn't specify the RetentionDays directly. This meant that it would rely on the server specified default. In the test case, it was then compared to a local object which had a value different from the default which was causing the test to fail. Rather than change the local value to match the server side default, we instead pass the local value into the test so that it is created with the non-default value.
Previously, the testDedicatedClusterResource test was requesting 2VCPU clusters which was failing during an actual acceptance test. This updates it to use 4VCPU. We additionally had to increase the scale step to 8VCPU to provide a real value that would necessitate an update. additionaly, we update the default from 2 to 4 in the advanced example.
fantapop
force-pushed
the
fantapop/CC-30497-terraform-support-cidr-range-attribute-on-cluster-creation
branch
from
5656c89
to
4caea03
Compare
We update the cockcroach-cloud-sdk-go to get changes for supporting cidr_range in clusters as well as JWT authentication in the client.
fantapop
force-pushed
the
fantapop/CC-30497-terraform-support-cidr-range-attribute-on-cluster-creation
branch
from
4caea03
to
5263ba3
Compare
fantapop
deleted the
fantapop/CC-30497-terraform-support-cidr-range-attribute-on-cluster-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting the cidr_range value for GCP clusters.
This is ready for review. Once the SDK is tagged, I'll need to update a few files but nothing substantial will change.
As I was working through the tests, I found some other issues related to previous PRs. I included them as separate commits in this one but I can pull them out to separate PRs if desired.
Commit checklist
make generate)