Update to latest SDK in the Cloud 2.0 branch #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder to make sure to update the merge target to |
Use new plan types. Remove support for spend limits. Add support for provisioned clusters. Adjust to use *int64 for usage limit fields rather than int64.
Previously, the TF provider raised an error when the primary attribute was
specified in multiple regions, even when false in all but one region, e.g.:
regions = [
{
name = "eu-west-1"
primary = true
},
{
name = "eu-west2"
primary = false
},
{
name = "ap-south-1"
primary = false
},
]
This PR fixes that by adding some custom validation logic rather than using
the built-in config validators.
Fixes: CC-27160
Make the "plan" attribute on the "cluster" resource writable so that it can be set by users who intend to upgrade/downgrade the plan. Keep the attribute as computed so that the system will set the value if it is not provided by the user. Release note: Support upgrade of plans via changes to the "plan" attribute on the "cluster" resource.
Rename the `provisioned_capacity` field to `provisioned_vcpus` and update all tests and examples to use the vCPUs unit rather than request units by dividing by 500. This is part of the overall migration to vCPUs for Cloud 2.0.
Add tests for downgrading from the STANDARD plan to the BASIC plan.
Previously, the Plan field was not passed to the CreateCluster API, even if it was explicitly set by the user. This prevented the server from validating the cluster configuration. For example, the server was not able to return an error when Plan=BASIC and provisioned_vcpus are set. The fix is to pass the Plan field to CreateCluster if the user explicitly sets it.
fantapop
force-pushed
the
fantapop/cloud-20-take-2
branch
from
bf7e71e
to
ee7a8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andy-kimball I've rebuilt the cloud 2.0 branch with the latest sdk branch that I also tagged you on. Let me know if these look reasonable and I'll force push them over the existing cloud 2.0 branches.