Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private_endpoint_services: fix backwards compat bug #214

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

carloruiz
Copy link
Contributor

@carloruiz carloruiz commented Jun 7, 2024

Previously, when reading the private_endpoint_services resource for AWS the clusters, the '.aws' field remained unset, despite expectations otherwise. This commit fixes the bug to ensure that field remains set.

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@carloruiz carloruiz requested a review from fantapop June 7, 2024 21:56
@carloruiz carloruiz force-pushed the fix-backwards-compat-privatelink-bug branch from e1ab4ac to 032d56e Compare June 7, 2024 21:58
Previously, when reading this resource for AWS the clusters, the '.aws'
remained unset, despite expectations otherwide. This commit fixes the
bug to ensure that field remains set.
@carloruiz carloruiz force-pushed the fix-backwards-compat-privatelink-bug branch from 032d56e to a5563ab Compare June 7, 2024 22:32
@carloruiz carloruiz requested a review from fantapop June 7, 2024 22:33
@carloruiz
Copy link
Contributor Author

Taged this with v1.7.6

Copy link
Collaborator

@fantapop fantapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carloruiz carloruiz merged commit 36196f3 into main Jun 7, 2024
5 of 6 checks passed
@carloruiz carloruiz deleted the fix-backwards-compat-privatelink-bug branch June 7, 2024 23:48
@carloruiz
Copy link
Contributor Author

TFTR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants