Allow enabling log export for serverless clusters. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaylim-crl
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
LGTM.
super nit: if we could add a test, that would be great, but I don't feel strongly. This is what I did back then for IP allowlists: https://github.com/cockroachdb/terraform-provider-cockroach/pull/133/files
|
Can you update https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/CHANGELOG.md as well, i.e. the |
alyshanjahani-crl
force-pushed
the
serverless-log-export
branch
from
f5c4847
to
b6c0f18
Compare
alyshanjahani-crl
force-pushed
the
serverless-log-export
branch
from
b6c0f18
to
3ba3ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.