Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: split release into pre-release-ci and release (manual) #164

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jaylim-crl
Copy link
Contributor

Previously, we run the release workflow automatically whenever a v* tag
gets pushed. The existing workflow does not work because the tests can be
flaky. When that happens, there's no way to release a new TF version since
goreleaser will only run once all the acceptance tests pass.

Until the flakiness goes away, we will split the release workflow into
two: pre-release-ci (that runs automatically like before), and release (which
has to be triggered manually after all the acceptance tests are triaged).

Commit checklist

  • Changelog -- irrelevant
  • Doc gen (make generate) -- irrelevant
  • Integration test(s) -- irrelevant
  • Acceptance test(s) -- irrelevant
  • Example(s) -- irrelevant

…ual)

Previously, we run the release workflow automatically whenever a v* tag
gets pushed. The existing workflow does not work because the tests can be
flaky. When that happens, there's no way to release a new TF version since
goreleaser will only run once all the acceptance tests pass.

Until the flakiness goes away, we will split the release workflow into
two: pre-release-ci (that runs automatically like before), and release (which
has to be triggered manually after all the acceptance tests are triaged).
@jaylim-crl jaylim-crl marked this pull request as ready for review September 13, 2023 18:58
@jaylim-crl
Copy link
Contributor Author

TFTR!

@jaylim-crl jaylim-crl merged commit 4c6f096 into main Sep 13, 2023
3 checks passed
@jaylim-crl jaylim-crl deleted the jay/split-workflow branch September 13, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants