Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/provider: add a new cockroach_private_endpoint_trusted_owner resource #159

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

jaylim-crl
Copy link
Contributor

@jaylim-crl jaylim-crl commented Aug 26, 2023

NOTE: This PR depends on the following:


internal/provider: add a new cockroach_private_endpoint_trusted_owner resource

This commit adds a new cockroach_private_endpoint_trusted_owner terraform
resource to manage private endpoint trusted owner entries.

docs: update docs to include cockroach_private_endpoint_connection

This commit updates the docs to include the new
cockroach_private_endpoint_connection resource. At the same time, we add
an example for such a resource, and update the CHANGELOG file as well.


Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@jaylim-crl
Copy link
Contributor Author

jaylim-crl commented Aug 27, 2023

Ran the acceptance tests against staging:

$ TF_ACC=1 go test -test.v -run TestAccDedicatedPrivateEndpointTrustedOwnerResource -timeout 120m -parallel 100 ./internal/provider/
=== RUN   TestAccDedicatedPrivateEndpointTrustedOwnerResource
--- PASS: TestAccDedicatedPrivateEndpointTrustedOwnerResource (1291.43s)
PASS
ok  	github.com/cockroachdb/terraform-provider-cockroach/internal/provider	1291.787s

We'd have to flip the feature flag on the right production org before releasing a new provider version.

@jaylim-crl jaylim-crl force-pushed the jay/230825-trusted-owners-resource branch from dd466e9 to ce76042 Compare August 27, 2023 02:28
@jaylim-crl jaylim-crl marked this pull request as ready for review August 27, 2023 02:30
Copy link
Contributor

@erademacher erademacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Textbook resource implementation. Very nice.

Reviewed 5 of 5 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: 9 of 24 files reviewed, 1 unresolved discussion (waiting on @jaylim-crl, @jeffswenson, and @pjtatlow)


internal/provider/private_endpoint_trusted_owner_resource.go line 59 at r2 (raw file):

				Computed: true,
				PlanModifiers: []planmodifier.String{
					stringplanmodifier.RequiresReplace(),

nit: I don't think this does anything for a computed field.

@jaylim-crl jaylim-crl force-pushed the jay/230825-trusted-owners-resource branch from ce76042 to 84f4fa8 Compare August 29, 2023 20:39
… resource

This commit adds a new cockroach_private_endpoint_trusted_owner terraform
resource to manage private endpoint trusted owner entries.
This commit updates the docs to include the new
cockroach_private_endpoint_connection resource. At the same time, we add
an example for such a resource, and update the CHANGELOG file as well.
@jaylim-crl jaylim-crl force-pushed the jay/230825-trusted-owners-resource branch from 84f4fa8 to 15d8d6b Compare August 29, 2023 20:40
@jaylim-crl
Copy link
Contributor Author

TFTR!

@jaylim-crl jaylim-crl merged commit 2e0d6b7 into main Aug 29, 2023
3 checks passed
@jaylim-crl jaylim-crl deleted the jay/230825-trusted-owners-resource branch August 29, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants