Skip to content

Commit

Permalink
[CC-30294] don't wait for lock before cluster deletion
Browse files Browse the repository at this point in the history
Previously the api didn't allow deletion of locked clusters.  It now
does so waiting for the lock before deleting is just adding extra time
to apply the changes.  We now issue the delete right away.
  • Loading branch information
fantapop committed Oct 29, 2024
1 parent 9cc0df1 commit af19956
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Changed

- Allow removal (deletion) of locked clusters. The api now supports deletion
of locked clusters so we remove the wait prior to following through with the
deletion.

### Added

- Management of cluster backup settings is now supported using the
Expand Down
5 changes: 0 additions & 5 deletions internal/provider/cluster_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -1074,11 +1074,6 @@ func (r *clusterResource) Delete(
return
}

waitForClusterLock(ctx, state, r.provider.service, &resp.Diagnostics)
if resp.Diagnostics.HasError() {
return
}

// Get cluster ID from state
if !IsKnown(state.ID) {
return
Expand Down

0 comments on commit af19956

Please sign in to comment.