arenaskl: remove node.allocSize field #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Dec 10, 2024
The field was added in c34894c and has been unused since c34894c. The `node` struct remains the same size due to padding. I found this while looking into cache misses in the memtable's arena-backed skiplist and exploring ways (e.g. value separation, value + key suffix separation) to improve memory locality. So far, I haven't found anything that shows promise on microbenchmarks.
nvanbenschoten
force-pushed
the
nvanbenschoten/sklAllocSize
branch
from
9133177 to
77ec92e
Compare
RaduBerinde
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field was added in c34894c and has been unused since c34894c.
The
nodestruct remains the same size due to padding.I found this while looking into cache misses in the memtable's arena-backed skiplist and exploring ways (e.g. value separation, value + key suffix separation) to improve memory locality. So far, I haven't found anything that shows promise on microbenchmarks.