crl-release-24.3: backport sstable writer bug fixes #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the EstimatedSize method of the columnar sstable writer would panic when the writer was configured with DisableValueBlocks enabled.
When keys are written to a sstable writer out-of-order, the writer returns an error message. The error messages returned from the row-based and column-based writers varied, in part because the columnar writer did not readily have the previous key at hand. This commit adapts the column writer to synthesize the previous user key for the purpose of embedding it within the returned error message.
|
This change is |
RaduBerinde
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
24.3 backports of #4146 and #4147