-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wal: implement failoverManager.{Obsolete,Stats} and log recycling #3328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @jbowens)
wal/failover_manager_test.go
line 496 at r1 (raw file):
// TODO(sumeer): test failoverManager.{List,Obsolete,Stats} // TODO(sumeer): test failoverWriter.getLog
The todos to test the new code. Existing tests pass.
If you need these changes merged to get unblocked, I can write the tests in a followup PR.
37c4058
to
0b6f1a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @jbowens)
wal/failover_manager_test.go
line 496 at r1 (raw file):
Previously, sumeerbhola wrote…
The todos to test the new code. Existing tests pass.
If you need these changes merged to get unblocked, I can write the tests in a followup PR.
tests are done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 8 files at r1, 2 of 5 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: 8 of 11 files reviewed, 2 unresolved discussions (waiting on @sumeerbhola)
wal/failover_manager.go
line 602 at r3 (raw file):
wm.mu.Lock() defer wm.mu.Unlock() wm.mu.closedWALs = append(wm.mu.closedWALs, wm.mu.ww.getLog())
wdyt of passing the logicalLogWithSizesEtc
in to the writerClosed
callback to make this control flow a little more explicit?
Informs cockroachdb#3230 Informs CRDB-35401
0b6f1a0
to
2bcecd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR!
Reviewable status: 5 of 11 files reviewed, 2 unresolved discussions (waiting on @jbowens)
wal/failover_manager.go
line 602 at r3 (raw file):
Previously, jbowens (Jackson Owens) wrote…
wdyt of passing the
logicalLogWithSizesEtc
in to thewriterClosed
callback to make this control flow a little more explicit?
Done
following test failure is unrelated:
|
Informs #3230
Informs CRDB-35401