meta: rework external ingest generation #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
meta-ext-rework
branch
from
9802657 to
86e1e4e
Compare
Rework how we generate non-overlapping external ingestions to have more freedom in selecting the bounds for each object. This will make adding prefix replacement possible. We also stop using `UniqueKeys` to generate the bounds which can fail occasionally.
RaduBerinde
force-pushed
the
meta-ext-rework
branch
from
86e1e4e to
7bae683
Compare
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how we generate non-overlapping external ingestions to have
more freedom in selecting the bounds for each object. This will make
adding prefix replacement possible.
We also stop using
UniqueKeysto generate the bounds which can failoccasionally.
Fixes #3317.