db: prefix replacement fixes #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Feb 20, 2024
The prefix replacing iterators did not support arguments that don't start with the synthetic prefix. We fix this by adding a `keyInRange` argument that we can compare against when we are outside the synthetic prefix range to figure out which side we are on. We also fix assertions in `maybeVerifyKey` which were not correct when prefix replacement is used.
|
Gave this a quick rebase to resolve the conflicts it got with the |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefix replacing iterators did not support arguments that don't
start with the synthetic prefix. We fix this by adding a
keyInRangeargument that we can compare against when we are outside the synthetic
prefix range to figure out which side we are on.
We also fix assertions in
maybeVerifyKeywhich were not correct whenprefix replacement is used.
Fixes #3319.