tool: adapt find command to explicitly track paths, filenames #3315
Conversation
Previously, the find tool used a map[base.DiskFileNum]string to record file paths across all file types. With cockroachdb#3230, WALs will need separate file path tracking because a single file number may actually consist of several physical files at several unique file paths. To avoid any confusion after this change is made, paths are now propagated alongside disk file numbers.
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @aadityasondhi)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aadityasondhi and @jbowens)
tool/find.go line 80 at r1 (raw file):
type fileLoc struct { base.DiskFileNum path string
won't we need the FS too? Is that for a future PR when we add a second FS to pebble.Options, and this tool lists logs in both?
There was a problem hiding this comment.
TFTRs!
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aadityasondhi and @sumeerbhola)
tool/find.go line 80 at r1 (raw file):
Previously, sumeerbhola wrote…
won't we need the FS too? Is that for a future PR when we add a second FS to
pebble.Options, and this tool lists logs in both?
yeah, I'm planning on either adding it in that PR or further tweaking the wal.Logs type so that the find tool doesn't use fileLoc for WALs at all. I'm not sure what'll shake out yet, but I figured regardless it would be confusing to maintain the base.DiskFileNum -> path map if it didn't hold for all disk file nums.
Previously, the find tool used a map[base.DiskFileNum]string to record file paths across all file types. With #3230, WALs will need separate file path tracking because a single file number may actually consist of several physical files at several unique file paths. To avoid any confusion after this change is made, paths are now propagated alongside disk file numbers.