sstable: remove global seq num property #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
seq-num-reader
branch
2 times, most recently
from
a5ccde4 to
8499201
Compare
|
We will be able to move PrefixReplacement from |
RaduBerinde
force-pushed
the
seq-num-reader
branch
2 times, most recently
from
d1ab47f to
3403bf8
Compare
jbowens
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Nice!
Sorry for the delay
Reviewed 7 of 7 files at r1, 57 of 57 files at r4, 9 of 10 files at r5, 17 of 55 files at r6, all commit messages.
Reviewable status: 27 of 65 files reviewed, all discussions resolved (waiting on @itsbilal and @msbutler)
|
TFTR! |
RaduBerinde
force-pushed
the
seq-num-reader
branch
from
3403bf8 to
7478a2f
Compare
This change removes the "global seq num" sstable property and instead passes it to iterators, as a `SyntheticSeqNum`. This cleans up a lot of the code that manipulated the global seq num in the reader and allows the same external file backing to be shared. As part of this change, we create a new struct `IterTransforms` and move the synthetic suffix as well as `hideObsoletePoints` to this struct. This cleans up the call sites, and allows easily adding more transforms in the future (e.g prefix replacement). We add a method on `FileMetadata` that generates the proper `IterTransforms` for that table.
RaduBerinde
force-pushed
the
seq-num-reader
branch
from
7478a2f to
17e4cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only for the top commit (the rest is #3297).
sstable: remove global seq num property
This change removes the "global seq num" sstable property and instead
passes it to iterators, as a
SyntheticSeqNum. This cleans up a lotof the code that manipulated the global seq num in the reader and
allows the same external file backing to be shared.
As part of this change, we create a new struct
IterTransformsandmove the synthetic suffix as well as
hideObsoletePointsto thisstruct. This cleans up the call sites, and allows easily adding more
transforms in the future (e.g prefix replacement).
We add a method on
FileMetadatathat generates the properIterTransformsfor that table.