sstable: update fixtures to TableFormatPebblev1 #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
make-table
branch
from
9a2035c to
f81ac51
Compare
We will soon no longer support the LevelDB format, so we remove this test file.
This change cleans up and moves the code that builds test SSTs, so that it will be accessible from a program that generates the fixtures. We also rewrite the fixture metadata in a more readable format and we add the missing info for "h.table-bloom.no-compression.sst". make-table: make-table.go go run ./make-table.go
Replace the C program with a Go program that calls into the sstable test fixtures code. We also remove `h.block-bloom.no-compression.sst` which is of very little use.
We regenerate the fixtures at the Pebblev1 version - earlier versions will soon be deprecated.
RaduBerinde
force-pushed
the
make-table
branch
from
f81ac51 to
92ee370
Compare
jbowens
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 4 of 4 files at r2, 7 of 7 files at r3, 9 of 9 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #3064.
sstable: remove h.ldb
We will soon no longer support the LevelDB format, so we remove this
test file.
sstable: refactor test fixtures
This change cleans up and moves the code that builds test SSTs, so
that it will be accessible from a program that generates the fixtures.
We also rewrite the fixture metadata in a more readable format and we
add the missing info for "h.table-bloom.no-compression.sst".
make-table: make-table.go
go run ./make-table.go
sstable: replace make-table.cc
Replace the C program with a Go program that calls into the sstable
test fixtures code.
We also remove
h.block-bloom.no-compression.sstwhich is of verylittle use.
sstable: update fixtures to TableFormatPebblev1
We regenerate the fixtures at the Pebblev1 version - earlier versions
will soon be deprecated.