Disable RocksDB sstable extensions with TableFormatLevelDB #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Currently this disables usage of the RocksDB sstable footer and two-level indexes. Fixes #285
petermattis
force-pushed
the
pmattis/leveldb
branch
from
b2758c2 to
b4d7234
Compare
sumeerbhola
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
what is the motivation for this change?
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @ajkr, @itsbilal, and @sumeerbhola)
sumeerbhola
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
never mind. I missed the Fixes #285
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @ajkr and @itsbilal)
petermattis
commented
Sep 20, 2019
There was a problem hiding this comment.
TFTR!
never mind. I missed the Fixes #285
Another phrasing would be: if we're told to use the LevelDB format, make sure the resulting sstable is readable by LevelDB.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @ajkr and @itsbilal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this disables usage of the RocksDB sstable footer and
two-level indexes.
Fixes #285