metamorphic: fix format major version ratcheting and parsing #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
force-pushed
the
fix-deletesized-meta
branch
from
d568fb2 to
8956c1a
Compare
Fix three bugs in the metamorphic tests' use of format major versions. First, during op generation, the code failed to add the minimum format major version back to the randomly generated value. This prevented format major versions from being ratcheted up sufficiently high. Second, during options generation, randomized options would only use format major verisons as recent as FormatNewest (which excluded the two experimental format major versions which have not yet been stabilized). Third, parsing format major version strings could fail for some values because ParseUint interpreted the leading `0` as indicating an octal value because the base argument was unspecified.
Previously DELSIZED keys were written with value sizes over a much larger magnitude than the actual values persisted. This made it very unlikely a DELSIZED key ever was the same size as the value it deleted.
Add a standard metamorphic tests options configuration that uses the latest format major version from the start of the test.
Setting the new isObsolete bit can cause missing keys. See cockroachdb#2705 for tracking fixing.
jbowens
force-pushed
the
fix-deletesized-meta
branch
from
8956c1a to
1bab415
Compare
Support exercising the new ExperimentalFormatVirtualSSTables format major version now.
jbowens
changed the title
RaduBerinde
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few bugs in the metamorphic tests' use of format major versions. These bugs were hiding an issue with the new obsolete-bit in the sstable format, and so I've temporarily disabled that codepath.