db: improve delete pacing #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
deletion-rate-hist-2
branch
from
9c25720 to
ca89ca2
Compare
jbowens
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Looks great!
Reviewed 22 of 22 files at r1, 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 22 files reviewed, 1 unresolved discussion (waiting on @RaduBerinde)
pacer.go line 169 at r3 (raw file):
for h.currEpoch < epoch { h.currEpoch++ // Forget the data for the oldest second.
nit: s/second/epoch/
Delete pacing is currently an on or off decision. If we are running out of space or have too many obsolete bytes in relation to live bytes, we disable pacing. Otherwise we pace at the configured rate (128MB by default in CRDB). This change improves pacing by keeping track of the average deletion rate over the last 5 minutes and increasing the target rate to match this rate if necessary. The intention is to avoid deletions lagging behind. Fixes cockroachdb#2662.
RaduBerinde
force-pushed
the
deletion-rate-hist-2
branch
from
ca89ca2 to
df16d0f
Compare
RaduBerinde
commented
Jun 27, 2023
There was a problem hiding this comment.
TFTR!
Reviewable status: 1 of 22 files reviewed, all discussions resolved (waiting on @jbowens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete pacing is currently an on or off decision. If we are running
out of space or have too many obsolete bytes in relation to live
bytes, we disable pacing. Otherwise we pace at the configured rate
(128MB by default in CRDB).
This change improves pacing by keeping track of the average deletion
rate over the last 5 minutes and increasing the target rate to match
this rate if necessary. The intention is to avoid deletions lagging
behind.
Fixes #2662.