db: don't use internal types in ScanInternal #2635
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @itsbilal and @sumeerbhola)
scan_internal.go line 851 at r1 (raw file):
// InternalRangeKey is a type alias that exports keyspan.Key, for use with // ScanInternal. Has a helper method to decode the Kind of the trailer. type InternalRangeKey = keyspan.Key
You can use the rangekey.Key type that already reexports keyspan.Key:
Line 15 in 2fed2e7
This change updates the ScanInternal function signature to not use the internal keyspan.Key type. Instead we use the rangekey.Key type alias that exports it. Also update the pointCollapsingIter to just call SeekGE in NextPrefix instead of panicking. Necessary for cockroachdb/cockroach#103028.
itsbilal
force-pushed
the
disagg-replicate-misc-fixes
branch
from
c05418d to
16e353f
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @jbowens and @sumeerbhola)
scan_internal.go line 851 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
You can use the
rangekey.Keytype that already reexportskeyspan.Key:Line 15 in 2fed2e7
Done.
There was a problem hiding this comment.
Reviewed 3 of 4 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @sumeerbhola)
This change updates the ScanInternal function signature to not use the internal keyspan.Key type. Instead we use the new InternalRangeKey type alias that exports it.
Also update the pointCollapsingIter to just call SeekGE in NextPrefix instead of panicking.
Necessary for cockroachdb/cockroach#103028.