Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crl-release-23.1: revert vfs: include size of write in DiskSlowInfo #2525

Merged
merged 2 commits into from
May 15, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented May 12, 2023

This backport appears to be origin of recent disk-stall detection roachtest failures (eg, cockroachdb/cockroach#102946). I haven't identified what the exact bug is.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens requested review from a team and sumeerbhola May 15, 2023 15:23
Copy link
Contributor

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this. LGTM.

@jbowens
Copy link
Collaborator Author

jbowens commented May 15, 2023

tftr!

@jbowens jbowens merged commit 9f426d5 into crl-release-23.1 May 15, 2023
@jbowens jbowens deleted the 23.1-fork branch May 15, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants