crl-release-23.1: vfs: include size of write in DiskSlowInfo #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the size of a write to DiskSlowInfo, in cases where a write is sized. A small write stalling out points at file system / disk issues, while a large write taking time to complete may indicate CRDB issues with a certain workload, etc.
When a disk stall is detected, the operation and path of the file are logged. Currently, in Cockroach, the path is redacted as it is not marked as safe. As a path in a production environment could contain sensitive information (we have no control over how a user configures the directory in which they use for the Pebble store), we want to avoid leaking too much information. Only take the basename of the file, and mark this as safe. The filenames that Pebble uses are well-formed, and should not contain sensitive information.
|
This change is |
|
Figured these would be useful in 23.1. |
RaduBerinde
approved these changes
Apr 27, 2023
joshimhoff
approved these changes
Apr 28, 2023
|
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2281 and #2499 to 23.1.
vfs: include size of write in DiskSlowInfo
This commit adds the size of a write to DiskSlowInfo, in cases where a write is
sized. A small write stalling out points at file system / disk issues, while
a large write taking time to complete may indicate CRDB issues with a certain
workload, etc.
vfs: mark file basename as safe to avoid log redaction
When a disk stall is detected, the operation and path of the file are
logged. Currently, in Cockroach, the path is redacted as it is not
marked as safe.
As a path in a production environment could contain sensitive
information (we have no control over how a user configures the directory
in which they use for the Pebble store), we want to avoid leaking too
much information. Only take the basename of the file, and mark this as
safe. The filenames that Pebble uses are well-formed, and should not
contain sensitive information.