sstable: fix error path in writer.Close #2380
Merged
+23
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
`Close()` records any error encountered and exits early if called again. One of the return paths was not setting `w.err`, possibly causing the panic in github.com/cockroachdb/cockroach/issues/97350. This change fixes this and improves the structure of the function - instead of each exit path having to set `w.err`, we set it in the deferred function.
RaduBerinde
force-pushed
the
sstwriter-double-close
branch
from
02d0a70 to
bb5f55b
Compare
jbowens
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Nice
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close()records any error encountered and exits early if called again. One of the return paths was not settingw.err, possibly causing the panic in github.com/cockroachdb/cockroach/issues/97350.This change fixes this and improves the structure of the function - instead of each exit path having to set
w.err, we set it in the deferred function.