internal/keyspan: lift visibility filtering out of Seek{GE,LE} #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Alter `keyspan.SeekGE` and `keyspan.SeekLE` to omit any sequence number filtering. The caller must now filter a Span's keys if necessary. This avoids extra work in the case that there are no visible keys overlapping the search key. Previously SeekGE and SeekLE would next or prev until they found a visible key. Now, the caller can simply use the empty span. This is partially motivated by the batch range deletion slowdown observed in impact.
nicktrav
approved these changes
May 17, 2022
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
jbowens
commented
May 18, 2022
There was a problem hiding this comment.
TFTR!
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter
keyspan.SeekGEandkeyspan.SeekLEto omit any sequence numberfiltering. The caller must now filter a Span's keys if necessary. This avoids
extra work in the case that there are no visible keys overlapping the search
key. Previously SeekGE and SeekLE would next or prev until they found a visible
key. Now, the caller can simply use the empty span.
This is partially motivated by the batch range deletion slowdown observed in
#1675.