db: remove unnecessary key clones during ingest load #1527
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During ingest loads, the smallest and largest bounds for point and ranges are calculated. The point and range key bounds are cloned from an iterator. When setting the overall bounds for the table, the point and / or range key bounds can be reused for `Smallest` and `Largest`, as the former are stable. Remove the unnecessary key clones. Follow up from cockroachdb#1521.
|
This change is |
sumeerbhola
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @jbowens)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During ingest loads, the smallest and largest bounds for point and
ranges are calculated. The point and range key bounds are cloned from an
iterator. When setting the overall bounds for the table, the point and /
or range key bounds can be reused for
SmallestandLargest, as theformer are stable.
Remove the unnecessary key clones.
Follow up from #1521.