db: save level iter debug output before closing #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the level checker encounters a violation an the iterator for the last level has been closed, the debug string providing information on the level and the file is lost. Save the debug string for potential use after the iterator is closed. ``` // Before checker failed with error: found InternalKey zzqwavxgrec@12#4092,SINGLEDEL in L0.2: fileNum=000830 and InternalKey zzqwavxgrec@12#4627,DEL in %!s(<nil>) // After checker failed with error: found InternalKey zzqwavxgrec@12#4092,SINGLEDEL in L0.2: fileNum=000830 and InternalKey zzqwavxgrec@12#4627,DEL in L6: fileNum=000997 ``` Related to cockroachdb#1459.
|
This change is |
jbowens
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Nice, had a similar commit staged locally :)
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Great minds ... something something. TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the level checker encounters a violation an the iterator
for the last level has been closed, the debug string providing
information on the level and the file is lost.
Save the debug string for potential use after the iterator is closed.
Related to #1459.