-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove support for Go v1.14 #1241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jbowens and @nicktrav)
.travis.yml, line 21 at r1 (raw file):
go: 1.14.x os: linux script: make test
I don't think we're using Travis anymore. @rail can we remove this file now?
.github/workflows/ci.yaml, line 19 at r1 (raw file):
go: - "1.15" - "1.16"
Should we add support for 1.17
?
Kill it with fire! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I shall amend this to rip out the TravisCI, and add Go 1.17 to the matrix.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jbowens and @nicktrav)
d286405
to
be3374a
Compare
Remove Go version 1.14 from the test matrix. Add version 1.17. Remove the obsolete TravisCI build configuration.
be3374a
to
38dd75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @jbowens and @nicktrav)
Only test against Go versions 1.15 and 1.16.