Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove support for Go v1.14 #1241

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

nicktrav
Copy link
Contributor

Only test against Go versions 1.15 and 1.16.

@nicktrav nicktrav requested review from jbowens and a team August 27, 2021 00:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jbowens and @nicktrav)


.travis.yml, line 21 at r1 (raw file):

      go: 1.14.x
      os: linux
      script: make test

I don't think we're using Travis anymore. @rail can we remove this file now?


.github/workflows/ci.yaml, line 19 at r1 (raw file):

        go:
          - "1.15"
          - "1.16"

Should we add support for 1.17?

@rail
Copy link
Member

rail commented Aug 27, 2021

@rail can we remove this file now?

Kill it with fire! :)

Copy link
Contributor Author

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I shall amend this to rip out the TravisCI, and add Go 1.17 to the matrix.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jbowens and @nicktrav)

@nicktrav nicktrav force-pushed the nickt.go-1.14 branch 3 times, most recently from d286405 to be3374a Compare August 27, 2021 14:45
Remove Go version 1.14 from the test matrix. Add version 1.17.

Remove the obsolete TravisCI build configuration.
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @jbowens and @nicktrav)

@nicktrav nicktrav merged commit ff43a58 into cockroachdb:master Aug 27, 2021
@nicktrav nicktrav deleted the nickt.go-1.14 branch August 27, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants