db: fix bug in seek noop optimization and add more testing #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SeekLT had a bug that included the equality case in the comparison. - Added an explicit error handling test, that checks that the optimization is not used when the InternalIterator returns an error. This test also exercises some non-error cases, including the bug. - Added randomization on when the optimization is applied when invariants.Enabled is true. - Added a comment explaining why this optimization is not used when the batch is non-nil. Also, we no longer copy the seek key when batch is non-nil, since that copy is wasted. - Added support for Iterator.Clone to the metamorphic test.
|
This change is |
jbowens
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Reviewed 2 of 7 files at r1.
Reviewable status: 2 of 7 files reviewed, all discussions resolved (waiting on @itsbilal and @petermattis)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the comparison.
that the optimization is not used when the
InternalIterator returns an error. This test also
exercises some non-error cases, including the bug.
applied when invariants.Enabled is true.
is not used when the batch is non-nil. Also, we
no longer copy the seek key when batch is non-nil,
since that copy is wasted.
test.