Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: add an Iterator.Clone to iterate over the same db state #1033

Merged
merged 1 commit into from
Dec 23, 2020
Merged

db: add an Iterator.Clone to iterate over the same db state #1033

merged 1 commit into from
Dec 23, 2020

Conversation

sumeerbhola
Copy link
Collaborator

@cockroach-teamcity
Copy link
Member

This change is Reviewable

itsbilal
itsbilal approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jbowens and @petermattis)

@sumeerbhola
Copy link
Collaborator Author

TFTR!

@sumeerbhola sumeerbhola merged commit 108cd02 into cockroachdb:master Dec 23, 2020
@sumeerbhola sumeerbhola deleted the iter_clone branch October 26, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsbilal itsbilal itsbilal approved these changes

@jbowens jbowens Awaiting requested review from jbowens

@petermattis petermattis Awaiting requested review from petermattis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumeerbhola @cockroach-teamcity @itsbilal