-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed #3594
Comments
github.com/cockroachdb/pebble/internal/metamorphic.TestMeta failed with artifacts on refs/heads/master @ f03e7efeebfd:
HelpTo reproduce, try: go test -tags 'invariants' -exec 'stress -p 1' -timeout 0 -test.v -run 'TestMeta$' ./internal/metamorphic -seed 1715059629640823123 -ops "uniform:5000-10000" |
|
Saw another failure on #3593.
|
github.com/cockroachdb/pebble/internal/metamorphic.TestMeta failed with artifacts on refs/heads/master @ 98cadc9f9bcd:
HelpTo reproduce, try: go test -tags 'invariants' -exec 'stress -p 1' -timeout 0 -test.v -run 'TestMeta$' ./internal/metamorphic -seed 1715141186055399080 -ops "uniform:5000-10000" |
Investigating with seed
|
github.com/cockroachdb/pebble/internal/metamorphic.TestMeta failed with artifacts on refs/heads/master @ 4301b8f511d9:
HelpTo reproduce, try: go test -tags 'invariants' -exec 'stress -p 1' -timeout 0 -test.v -run 'TestMeta$' ./internal/metamorphic -seed 1715227882649100225 -ops "uniform:5000-10000" |
Before the recent compaction cleanup, the output table writer was initialized lazily, which means that until the first key was written the estimated size was 0. So even with a tiny target size, we will get at least one point key and any associated spans. Now the table writer is initialized up front and the estimated size of an empty table writer is 8. When the target file size is less than that, we try to split the table as soon as possible (and emit just a small piece of a span in many cases). These many tiny tables slow down the tests a lot, to the point of timing out certain operations. This change sets the minimum target file size in the metamorphic tests to 12. Fixes cockroachdb#3594 Fixes cockroachdb#3595
Before the recent compaction cleanup, the output table writer was initialized lazily, which means that until the first key was written the estimated size was 0. So even with a tiny target size, we will get at least one point key and any associated spans. Now the table writer is initialized up front and the estimated size of an empty table writer is 8. When the target file size is less than that, we try to split the table as soon as possible (and emit just a small piece of a span in many cases). These many tiny tables slow down the tests a lot, to the point of timing out certain operations. This change sets the minimum target file size in the metamorphic tests to 12. Fixes #3594 Fixes #3595
github.com/cockroachdb/pebble/internal/metamorphic.TestMeta failed with artifacts on refs/heads/master @ f03e7efeebfd:
Help
To reproduce, try:
This test on roachdash | Improve this report!
The text was updated successfully, but these errors were encountered: