Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run TestMetaTwoInstance nightly #3175

Closed
RaduBerinde opened this issue Dec 20, 2023 · 0 comments · Fixed by cockroachdb/cockroach#117654
Closed

run TestMetaTwoInstance nightly #3175

RaduBerinde opened this issue Dec 20, 2023 · 0 comments · Fixed by cockroachdb/cockroach#117654
Assignees
@RaduBerinde
Labels
A-storage T-storage

Comments

@RaduBerinde
Copy link
Member

We currently run TestMeta in the nightlies, but not TestMetaTwoInstance

CC @itsbilal
@RaduBerinde RaduBerinde mentioned this issue Dec 20, 2023
Closed
@RaduBerinde RaduBerinde self-assigned this Jan 9, 2024
@RaduBerinde RaduBerinde mentioned this issue Jan 11, 2024
Merged
craig bot pushed a commit to cockroachdb/cockroach that referenced this issue Jan 17, 2024
@fqazi @nvanbenschoten
@arulajmani @RaduBerinde @dt
Merge #115833 #117560 #117654 #117834
b743201 
115833: server: make SQL connection keep alive easily configurable r=fqazi a=fqazi

Previously, the only way to control the keep-alive time for CRDB was through the environment variable COCKROACH_SQL_TCP_KEEP_ALIVE, which set the keep-alive idle and probe times only. This was difficult to use, and the default meant that CRDB kept connections alive for 10 minutes of idle time. To help make this more configurable, we will introduce two cluster settings:  server.sql_tcp_keep_alive_probe_interval and server.sql_tcp_keep_alive_timeout. These settings will control the keep-alive probe / idle intervals, and the probe count (derived from the timeout) before the connection will be dropped.

Fixes: #115422

117560: kv: use correct strength for {Get,Scan,ReverseScan} for SKIP LOCKED r=nvanbenschoten a=arulajmani

See individual commits. 

117654: build: add TestMetaTwoInstance nightly run scripts r=RaduBerinde a=RaduBerinde

We also change the race build to run both flavors.

Fixes: cockroachdb/pebble#3175
Release note: None

117834: parser: fix string repr of ALTER ... START REPLICATION r=dt a=dt

Release note: none.
Epic: none.

Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Arul Ajmani <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: David Taylor <[email protected]>
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

Labels
A-storage T-storage
Projects
[Deprecated] Storage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add TestMetaTwoInstance nightly run scripts RaduBerinde/cockroach
1 participant
@RaduBerinde