Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metamorphic/crossversion: non-zero zombie file count #2708

Closed
jbowens opened this issue Jul 5, 2023 · 1 comment · Fixed by #2728
Closed

metamorphic/crossversion: non-zero zombie file count #2708

jbowens opened this issue Jul 5, 2023 · 1 comment · Fixed by #2728
Assignees
@itsbilal
Labels
A-storage T-storage

Comments

@jbowens
Copy link
Collaborator

jbowens commented Jul 5, 2023 

             === CONT  TestMeta/execution/random-016
            meta.go:208:
                ===== SEED =====
                1221656693780176453
                ===== ERR =====
                exit status 1
                ===== OUT =====
                Seed: 0
                dbRestartOp: non-zero zombie file count: 5

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_NightlyPebbleMetamorphicCrossversion/10780113?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true
@jbowens
Copy link
Collaborator Author

jbowens commented Jul 6, 2023 

=== CONT  TestMeta/execution/random-012
    meta.go:208: 
        ===== SEED =====
        1688621428134612498
        ===== ERR =====
        exit status 1
        ===== OUT =====
        Seed: 0
        dbRestartOp: non-zero zombie file count: 1
        
        ===== OPTIONS =====
        [Version]
          pebble_version=0.1

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_Pebble_Metamorphic/10797021?buildTab=artifacts#%2Fmeta;%2Ftmp;%2Fbazel-testlogs

@itsbilal itsbilal self-assigned this Jul 10, 2023
itsbilal added a commit to itsbilal/pebble that referenced this issue Jul 11, 2023
@itsbilal
db: Bring back call to deleteObsoleteFiles in Close()
70147cc 
Before cockroachdb#2641, we had a conditional to explicitly schedule deletion of
obsolete files in db.Close(). We took it out as part of the
deletion refactor as the comment on it made it seem no longer necessary.
However, the code for readState.unrefLocked(), which we call earlier in Close(),
explicitly states that it does not schedule obsolete file deletion and
that it expects the caller to schedule that. Since we're calling
readState.unrefLocked() here, we should be doing said deletion.

Fixes cockroachdb#2708.
@itsbilal itsbilal mentioned this issue Jul 11, 2023
Merged
itsbilal added a commit that referenced this issue Jul 11, 2023
@itsbilal
db: Bring back call to deleteObsoleteFiles in Close()
88bbab5 
Before #2641, we had a conditional to explicitly schedule deletion of
obsolete files in db.Close(). We took it out as part of the
deletion refactor as the comment on it made it seem no longer necessary.
However, the code for readState.unrefLocked(), which we call earlier in Close(),
explicitly states that it does not schedule obsolete file deletion and
that it expects the caller to schedule that. Since we're calling
readState.unrefLocked() here, we should be doing said deletion.

Fixes #2708.
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsbilal itsbilal

Labels
A-storage T-storage
Projects
[Deprecated] Storage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

db: Bring back call to deleteObsoleteFiles in Close() itsbilal/pebble
2 participants
@itsbilal @jbowens