Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: TestCleaner fails under the race build on master on linux #2560

Closed
bananabrick opened this issue May 24, 2023 · 1 comment · Fixed by #2607
Closed

db: TestCleaner fails under the race build on master on linux #2560

bananabrick opened this issue May 24, 2023 · 1 comment · Fixed by #2607

Comments

@bananabrick
Copy link
Contributor

arjunnair@gceworker-arjunnair:~/go/src/github.com/cockroachdb/pebble$ git branch
* master
  ve_enc_dec
arjunnair@gceworker-arjunnair:~/go/src/github.com/cockroachdb/pebble$ go test -race -exec 'stress' -run ^TestCleaner$

--- FAIL: TestCleaner (0.02s)
    datadriven.go:143: 
        testdata/cleaner:196:
         
        output didn't match expected:
        @@ -33,6 +33,10 @@
         remove: db1_wal/000002.log
         remove: db1_wal/000004.log
         remove: db1/000123.sst
         remove: db1/000456.sst
         remove: db1/OPTIONS-000003
        +open: db1/000005.sst
        +read-at(744, 53): db1/000005.sst
        +read-at(707, 37): db1/000005.sst
        +read-at(79, 628): db1/000005.sst
         
FAIL


ERROR: exit status 1

1 runs completed, 1 failures, over 0s
context canceled
FAIL
exit status 1
FAIL    github.com/cockroachdb/pebble   0.074s

This started failing more regularly due to #2484, but either way, it exists on master.

@RaduBerinde
Copy link
Member

The extra open is coming from maybeCollectTableStatsLocked()

@RaduBerinde RaduBerinde self-assigned this Jun 6, 2023
RaduBerinde added a commit to RaduBerinde/pebble that referenced this issue Jun 6, 2023
TestCleaner flakes because of table stats are retrieved
asynchronously. Disable table stats altogether.

Fixes cockroachdb#2560
RaduBerinde added a commit that referenced this issue Jun 6, 2023
TestCleaner flakes because of table stats are retrieved
asynchronously. Disable table stats altogether.

Fixes #2560
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants