Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: add format major version gating for flushable ingests #2292

Closed
bananabrick opened this issue Jan 31, 2023 · 3 comments · Fixed by #2363
Closed

db: add format major version gating for flushable ingests #2292

bananabrick opened this issue Jan 31, 2023 · 3 comments · Fixed by #2363

Comments

@bananabrick
Copy link
Contributor

No description provided.

@jbowens
Copy link
Collaborator

jbowens commented Feb 22, 2023

@bananabrick are you actively working on this? if not, can I move it back to 23.1 (and I can hopefully pick it up this week)

@bananabrick
Copy link
Contributor Author

@jbowens Haven't started it yet.

@jbowens
Copy link
Collaborator

jbowens commented Feb 27, 2023

Got it, I'll pick it up.

@jbowens jbowens assigned jbowens and unassigned bananabrick Feb 27, 2023
jbowens added a commit to jbowens/pebble that referenced this issue Feb 27, 2023
Introduce a new format major version that gates uses of flushable ingests and
the corresponding backwards-incompatible changes to the write-ahead log.

Close cockroachdb#2292.
jbowens added a commit to jbowens/pebble that referenced this issue Feb 28, 2023
Introduce a new format major version that gates uses of flushable ingests and
the corresponding backwards-incompatible changes to the write-ahead log. Also
invert the IngestSSTablesAsFlushable Option into DisableIngestAsFlushable,
enabling ingest-as-flushable by default on supported format major versions.

Close cockroachdb#2292.
jbowens added a commit that referenced this issue Feb 28, 2023
Introduce a new format major version that gates uses of flushable ingests and
the corresponding backwards-incompatible changes to the write-ahead log. Also
invert the IngestSSTablesAsFlushable Option into DisableIngestAsFlushable,
enabling ingest-as-flushable by default on supported format major versions.

Close #2292.
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants