-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db: add method to compute statistics over a key span #1996
Comments
This would have helped in https://github.com/cockroachlabs/support/issues/2107. See https://cockroachlabs.slack.com/archives/C04RXNF8THA/p1677782359190299 and earlier threads on the channel. |
We would want stats to count the internal keys (and bytes) and the keys covered by range tombstones (and classify them into whether they can be cheaply seeked over during iteration or not). And pace the scan, say 2MB/s (or configurable in the sql statement), so it does not impact foreground traffic. |
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: cockroachdb#1996
Created a new function `ScanStatistics` that returns counts of the different key kinds in Pebble (by level) as well as the number of snapshot keys. Also modified `ScanInternal` to surface the level of each key within each visitor function. Informs: #1996
In some issues (eg, cockroachlabs/support#1830) it would be useful to be able to get a better picture of the storage layer over a keyspan: eg, number of keys in each level, and what kinds. Maybe it could replace the specific
DB.EstimateDiskUsage
function.See cockroachdb/cockroach#94659 for the cockroach companion issue.
The text was updated successfully, but these errors were encountered: