Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metamorphic: consider running with configurations that alter the compression library #1705

Closed
Tracked by #2825
nicktrav opened this issue May 20, 2022 · 0 comments · Fixed by #2900
Closed
Tracked by #2825

Comments

@nicktrav
Copy link
Contributor

We currently test with the default codec (snappy at the time of writing). To give us better coverage, we should consider testing against configurations with a) a different codec to standard-000, and b) an LSM with a mixture of codecs for various levels (as opposed to the same library for all levels).

We'd update the code here, to set the codec, and possibly have a mixture of level configs:

var lopts pebble.LevelOptions
lopts.BlockRestartInterval = 1 + rng.Intn(64) // 1 - 64
lopts.BlockSize = 1 << uint(rng.Intn(24)) // 1 - 16MB
lopts.BlockSizeThreshold = 50 + rng.Intn(50) // 50 - 100
lopts.IndexBlockSize = 1 << uint(rng.Intn(24)) // 1 - 16MB
lopts.TargetFileSize = 1 << uint(rng.Intn(28)) // 1 - 256MB
opts.Levels = []pebble.LevelOptions{lopts}

@jbowens jbowens mentioned this issue Sep 5, 2023
18 tasks
jbowens added a commit to jbowens/pebble that referenced this issue Sep 14, 2023
In the metamorphic test runs with randomized options, vary the sstable
compression algorithm rather than always using the default Snappy compression
algorithm.

Close cockroachdb#1705.
jbowens added a commit that referenced this issue Sep 15, 2023
In the metamorphic test runs with randomized options, vary the sstable
compression algorithm rather than always using the default Snappy compression
algorithm.

Close #1705.
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant